-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CertificateAuthority customSetDefaults method #54
Conversation
if ackcompare.IsNil(a.ko.Spec.UsageMode) && ackcompare.IsNotNil(b.ko.Spec.UsageMode) { | ||
a.ko.Spec.UsageMode = defaultUsageMode | ||
if ackcompare.IsNil(desired.ko.Spec.UsageMode) && ackcompare.IsNotNil(latest.ko.Spec.UsageMode) { | ||
desired.ko.Spec.UsageMode = latest.ko.Spec.UsageMode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the naming is flipped.
You want to set latest/current to the desired state.
desired *resource, | ||
latest *resource, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know in the generator.yaml
there is a definition given with the parameters being a,b. Not sure how the generator works but wanted to call that out in case we need to fix generator.yaml
a *resource, | ||
b *resource, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update these names to be more descriptive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are just going to leave this the same as this is the standard naming scheme across all ACK controllers.
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anbaig, ndbhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
a
to the fields ofb
in customSetDefaults methodBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.